From 012b1cd79d3dd72f733f86c86ed8d7476c7e4beb Mon Sep 17 00:00:00 2001 From: TwistedUmbrellaX Date: Fri, 29 Mar 2024 21:44:25 -0400 Subject: [PATCH] fix: make settings great again auto and time stamps are intertwined already and the dividers should serve a purpose --- .../settings/PlayerSettingsActivity.kt | 12 ++-- .../res/layout/activity_player_settings.xml | 70 +++++++------------ .../res/layout/activity_settings_about.xml | 7 ++ .../res/layout/activity_settings_accounts.xml | 15 ++++ .../res/layout/activity_settings_anime.xml | 40 +++++------ .../res/layout/activity_settings_common.xml | 46 +++++------- .../layout/activity_settings_extensions.xml | 63 ++++++++--------- .../res/layout/activity_settings_manga.xml | 31 +++----- .../activity_settings_notifications.xml | 15 ++++ .../res/layout/activity_settings_theme.xml | 8 +++ app/src/main/res/values/strings.xml | 2 +- 11 files changed, 149 insertions(+), 160 deletions(-) diff --git a/app/src/main/java/ani/dantotsu/settings/PlayerSettingsActivity.kt b/app/src/main/java/ani/dantotsu/settings/PlayerSettingsActivity.kt index db68fe46..ec431643 100644 --- a/app/src/main/java/ani/dantotsu/settings/PlayerSettingsActivity.kt +++ b/app/src/main/java/ani/dantotsu/settings/PlayerSettingsActivity.kt @@ -137,11 +137,6 @@ class PlayerSettingsActivity : AppCompatActivity() { binding.playerSettingsAutoSkipOpEd.isEnabled = isChecked } - binding.playerSettingsTimeStampsAutoHide.isChecked = PrefManager.getVal(PrefName.AutoHideTimeStamps) - binding.playerSettingsTimeStampsAutoHide.setOnCheckedChangeListener { _, isChecked -> - PrefManager.setVal(PrefName.AutoHideTimeStamps, isChecked) - } - binding.playerSettingsTimeStampsProxy.isChecked = PrefManager.getVal(PrefName.UseProxyForTimeStamps) binding.playerSettingsTimeStampsProxy.setOnCheckedChangeListener { _, isChecked -> @@ -152,6 +147,13 @@ class PlayerSettingsActivity : AppCompatActivity() { PrefManager.getVal(PrefName.ShowTimeStampButton) binding.playerSettingsShowTimeStamp.setOnCheckedChangeListener { _, isChecked -> PrefManager.setVal(PrefName.ShowTimeStampButton, isChecked) + binding.playerSettingsTimeStampsAutoHide.isEnabled = isChecked + } + + binding.playerSettingsTimeStampsAutoHide.isChecked = PrefManager.getVal(PrefName.AutoHideTimeStamps) + binding.playerSettingsTimeStampsAutoHide.isEnabled = binding.playerSettingsShowTimeStamp.isChecked + binding.playerSettingsTimeStampsAutoHide.setOnCheckedChangeListener { _, isChecked -> + PrefManager.setVal(PrefName.AutoHideTimeStamps, isChecked) } // Auto diff --git a/app/src/main/res/layout/activity_player_settings.xml b/app/src/main/res/layout/activity_player_settings.xml index 83a40d61..393e50e4 100644 --- a/app/src/main/res/layout/activity_player_settings.xml +++ b/app/src/main/res/layout/activity_player_settings.xml @@ -491,37 +491,6 @@ app:showText="false" app:thumbTint="@color/button_switch_track" /> - - - - - - - + + android:text="@string/hide_skip_button" + android:textSize="14sp" /> + +