chore: lint performance optimization

This includes shadowed variables, unnecessary parameters, layouts with string literals, items that cause performance bottlenecks, and the merge of extension types into only the necessary separate classes.

app/src/main/java/ani/dantotsu/profile/ProfileFragment.kt

@@ -34,6 +34,7 @@ import ani.dantotsu.setSlideIn
 import ani.dantotsu.setSlideUp
 import ani.dantotsu.util.AniMarkdown.Companion.getFullAniHTML
 import ani.dantotsu.util.Logger
+import eu.kanade.tachiyomi.util.system.getSerializableCompat
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 
@@ -58,7 +59,7 @@ class ProfileFragment : Fragment() {
         super.onViewCreated(view, savedInstanceState)
         activity = requireActivity() as ProfileActivity
 
-        user = arguments?.getSerializable("user") as Query.UserProfile
+        user = arguments?.getSerializableCompat<Query.UserProfile>("user") as Query.UserProfile
         viewLifecycleOwner.lifecycleScope.launch(Dispatchers.IO) {
             model.setData(user.id)
         }

app/src/main/java/ani/dantotsu/profile/StatsFragment.kt

@@ -20,6 +20,7 @@ import ani.dantotsu.profile.ChartBuilder.Companion.StatType
 import ani.dantotsu.statusBarHeight
 import com.github.aachartmodel.aainfographics.aachartcreator.AAChartType
 import com.xwray.groupie.GroupieAdapter
+import eu.kanade.tachiyomi.util.system.getSerializableCompat
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
@@ -48,7 +49,7 @@ class StatsFragment :
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
         activity = requireActivity() as ProfileActivity
-        user = arguments?.getSerializable("user") as Query.UserProfile
+        user = arguments?.getSerializableCompat<Query.UserProfile>("user") as Query.UserProfile
 
         binding.statisticList.adapter = adapter
         binding.statisticList.recycledViewPool.setMaxRecycledViews(0, 0)
@@ -95,7 +96,7 @@ class StatsFragment :
                 }
             } else {
                 stats.removeAll(
-                    stats.filter { it?.id == Anilist.userid }
+                    stats.filter { it?.id == Anilist.userid }.toSet()
                 )
                 loadStats(type == MediaType.ANIME)
             }
@@ -445,6 +446,7 @@ class StatsFragment :
             }.toMutableList()
             chartPackets.clear()
             chartPackets.addAll(standardizedPackets)
+            @Suppress("UNCHECKED_CAST")
             val genreChart = ChartBuilder.buildChart(
                 activity,
                 ChartType.TwoDimensional,
@@ -499,6 +501,7 @@ class StatsFragment :
             }.toMutableList()
             chartPackets.clear()
             chartPackets.addAll(standardizedPackets)
+            @Suppress("UNCHECKED_CAST")
             val tagChart = ChartBuilder.buildChart(
                 activity,
                 ChartType.TwoDimensional,
@@ -553,6 +556,7 @@ class StatsFragment :
             }.toMutableList()
             chartPackets.clear()
             chartPackets.addAll(standardizedPackets)
+            @Suppress("UNCHECKED_CAST")
             val countryChart = ChartBuilder.buildChart(
                 activity,
                 ChartType.OneDimensional,
@@ -609,6 +613,7 @@ class StatsFragment :
             }.toMutableList()
             chartPackets.clear()
             chartPackets.addAll(standardizedPackets)
+            @Suppress("UNCHECKED_CAST")
             val voiceActorsChart = ChartBuilder.buildChart(
                 activity,
                 ChartType.TwoDimensional,
@@ -663,6 +668,7 @@ class StatsFragment :
             }.toMutableList()
             chartPackets.clear()
             chartPackets.addAll(standardizedPackets)
+            @Suppress("UNCHECKED_CAST")
             val studioChart = ChartBuilder.buildChart(
                 activity,
                 ChartType.TwoDimensional,
@@ -720,6 +726,7 @@ class StatsFragment :
             }.toMutableList()
             chartPackets.clear()
             chartPackets.addAll(standardizedPackets)
+            @Suppress("UNCHECKED_CAST")
             val staffChart = ChartBuilder.buildChart(
                 activity,
                 ChartType.TwoDimensional,

app/src/main/java/ani/dantotsu/profile/activity/FeedActivity.kt

@@ -61,7 +61,7 @@ class FeedActivity : AppCompatActivity() {
             }
         })
         binding.listBack.setOnClickListener {
-            onBackPressed()
+            onBackPressedDispatcher.onBackPressed()
         }
     }
 

app/src/main/java/ani/dantotsu/profile/activity/NotificationActivity.kt

@@ -58,7 +58,7 @@ class NotificationActivity : AppCompatActivity() {
         binding.followerGrid.visibility = ViewGroup.GONE
         binding.followerList.visibility = ViewGroup.GONE
         binding.listBack.setOnClickListener {
-            onBackPressed()
+            onBackPressedDispatcher.onBackPressed()
         }
         binding.listProgressBar.visibility = ViewGroup.VISIBLE
         val activityId = intent.getIntExtra("activityId", -1)