chore: lint performance optimization

This includes shadowed variables, unnecessary parameters, layouts with string literals, items that cause performance bottlenecks, and the merge of extension types into only the necessary separate classes.

app/src/main/java/ani/dantotsu/settings/SettingsActivity.kt

@@ -46,7 +46,6 @@ import ani.dantotsu.databinding.ActivitySettingsAboutBinding
 import ani.dantotsu.databinding.ActivitySettingsAccountsBinding
 import ani.dantotsu.databinding.ActivitySettingsAnimeBinding
 import ani.dantotsu.databinding.ActivitySettingsBinding
-import ani.dantotsu.download.DownloadedType
 import ani.dantotsu.databinding.ActivitySettingsCommonBinding
 import ani.dantotsu.databinding.ActivitySettingsExtensionsBinding
 import ani.dantotsu.databinding.ActivitySettingsMangaBinding
@@ -57,7 +56,7 @@ import ani.dantotsu.download.video.ExoplayerDownloadService
 import ani.dantotsu.downloadsPermission
 import ani.dantotsu.initActivity
 import ani.dantotsu.loadImage
-import ani.dantotsu.util.Logger
+import ani.dantotsu.media.MediaType
 import ani.dantotsu.navBarHeight
 import ani.dantotsu.notifications.TaskScheduler
 import ani.dantotsu.notifications.anilist.AnilistNotificationWorker
@@ -81,6 +80,7 @@ import ani.dantotsu.startMainActivity
 import ani.dantotsu.statusBarHeight
 import ani.dantotsu.themes.ThemeManager
 import ani.dantotsu.toast
+import ani.dantotsu.util.Logger
 import com.google.android.material.snackbar.Snackbar
 import com.google.android.material.textfield.TextInputEditText
 import eltos.simpledialogfragment.SimpleDialog
@@ -151,13 +151,13 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                                             salt
                                         )
                                     } catch (e: Exception) {
-                                        toast("Incorrect password")
+                                        toast(getString(R.string.incorrect_password))
                                         return@passwordAlertDialog
                                     }
                                     if (PreferencePackager.unpack(decryptedJson))
                                         restartApp()
                                 } else {
-                                    toast("Password cannot be empty")
+                                    toast(getString(R.string.password_cannot_be_empty))
                                 }
                             }
                         } else if (name.endsWith(".ani")) {
@@ -165,11 +165,11 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                             if (PreferencePackager.unpack(decryptedJson))
                                 restartApp()
                         } else {
-                            toast("Unknown file type")
+                            toast(getString(R.string.unknown_file_type))
                         }
                     } catch (e: Exception) {
                         e.printStackTrace()
-                        toast("Error importing settings")
+                        toast(getString(R.string.error_importing_settings))
                     }
                 }
             }
@@ -254,7 +254,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
             }
 
             val tag = "colorPicker"
-            CustomColorDialog().title("Custom Theme")
+            CustomColorDialog().title(R.string.custom_theme)
                 .colorPreset(originalColor)
                 .colors(this, SimpleColorDialog.MATERIAL_COLOR_PALLET)
                 .allowCustom(true)
@@ -271,7 +271,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
 
         val managers = arrayOf("Default", "1DM", "ADM")
         val downloadManagerDialog =
-            AlertDialog.Builder(this, R.style.MyPopup).setTitle("Download Manager")
+            AlertDialog.Builder(this, R.style.MyPopup).setTitle(R.string.download_manager)
         var downloadManager: Int = PrefManager.getVal(PrefName.DownloadManager)
         bindingCommon.settingsDownloadManager.setOnClickListener {
             val dialog = downloadManagerDialog.setSingleChoiceItems(
@@ -291,7 +291,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
             val filteredLocations = Location.entries.filter { it.exportable }
             selectedArray.addAll(List(filteredLocations.size - 1) { false })
             val dialog = AlertDialog.Builder(this, R.style.MyPopup)
-                .setTitle("Import/Export Settings")
+                .setTitle(R.string.import_export_settings)
                 .setMultiChoiceItems(
                     filteredLocations.map { it.name }.toTypedArray(),
                     selectedArray.toBooleanArray()
@@ -346,7 +346,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                 .setMessage(getString(R.string.purge_confirm, getString(R.string.anime)))
                 .setPositiveButton(R.string.yes) { dialog, _ ->
                     val downloadsManager = Injekt.get<DownloadsManager>()
-                    downloadsManager.purgeDownloads(DownloadedType.Type.ANIME)
+                    downloadsManager.purgeDownloads(MediaType.ANIME)
                     DownloadService.sendRemoveAllDownloads(
                         this,
                         ExoplayerDownloadService::class.java,
@@ -354,7 +354,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                     )
                     dialog.dismiss()
                 }
-                .setNegativeButton("No") { dialog, _ ->
+                .setNegativeButton(R.string.no) { dialog, _ ->
                     dialog.dismiss()
                 }
                 .create()
@@ -368,10 +368,10 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                 .setMessage(getString(R.string.purge_confirm, getString(R.string.manga)))
                 .setPositiveButton(R.string.yes) { dialog, _ ->
                     val downloadsManager = Injekt.get<DownloadsManager>()
-                    downloadsManager.purgeDownloads(DownloadedType.Type.MANGA)
+                    downloadsManager.purgeDownloads(MediaType.MANGA)
                     dialog.dismiss()
                 }
-                .setNegativeButton("No") { dialog, _ ->
+                .setNegativeButton(R.string.no) { dialog, _ ->
                     dialog.dismiss()
                 }
                 .create()
@@ -385,10 +385,10 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                 .setMessage(getString(R.string.purge_confirm, getString(R.string.novels)))
                 .setPositiveButton(R.string.yes) { dialog, _ ->
                     val downloadsManager = Injekt.get<DownloadsManager>()
-                    downloadsManager.purgeDownloads(DownloadedType.Type.NOVEL)
+                    downloadsManager.purgeDownloads(MediaType.NOVEL)
                     dialog.dismiss()
                 }
-                .setNegativeButton("No") { dialog, _ ->
+                .setNegativeButton(R.string.no) { dialog, _ ->
                     dialog.dismiss()
                 }
                 .create()
@@ -423,16 +423,16 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
             val alertDialog = AlertDialog.Builder(this, R.style.MyPopup)
                 .setTitle("User Agent")
                 .setView(dialogView)
-                .setPositiveButton("OK") { dialog, _ ->
+                .setPositiveButton(getString(R.string.ok)) { dialog, _ ->
                     PrefManager.setVal(PrefName.DefaultUserAgent, editText.text.toString())
                     dialog.dismiss()
                 }
-                .setNeutralButton("Reset") { dialog, _ ->
+                .setNeutralButton(getString(R.string.reset)) { dialog, _ ->
                     PrefManager.removeVal(PrefName.DefaultUserAgent)
                     editText.setText("")
                     dialog.dismiss()
                 }
-                .setNegativeButton("Cancel") { dialog, _ ->
+                .setNegativeButton(getString(R.string.cancel)) { dialog, _ ->
                     dialog.dismiss()
                 }
                 .create()
@@ -613,7 +613,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
             lifecycleScope.launch {
                 it.pop()
             }
-            openLinkInBrowser("https://www.buymeacoffee.com/rebelonion")
+            openLinkInBrowser(getString(R.string.coffee))
         }
         lifecycleScope.launch {
             binding.settingBuyMeCoffee.pop()
@@ -905,7 +905,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                 if (MAL.token != null) {
                     bindingAccounts.settingsMALLogin.setText(R.string.logout)
                     bindingAccounts.settingsMALLogin.setOnClickListener {
-                        MAL.removeSavedToken(it.context)
+                        MAL.removeSavedToken()
                         restartMainActivity.isEnabled = true
                         reload()
                     }
@@ -1060,7 +1060,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
         box?.setSingleLine()
 
         val dialog = AlertDialog.Builder(this, R.style.MyPopup)
-            .setTitle("Enter Password")
+            .setTitle(getString(R.string.enter_password))
             .setView(dialogView)
             .setPositiveButton("OK", null)
             .setNegativeButton("Cancel") { dialog, _ ->
@@ -1076,7 +1076,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
                 dialog.dismiss()
                 callback(password)
             } else {
-                toast("Password cannot be empty")
+                toast(getString(R.string.password_cannot_be_empty))
             }
         }
         box?.setOnEditorActionListener { _, actionId, _ ->
@@ -1090,7 +1090,7 @@ class SettingsActivity : AppCompatActivity(), SimpleDialog.OnDialogResultListene
         val subtitleTextView = dialogView.findViewById<TextView>(R.id.subtitle)
         subtitleTextView?.visibility = View.VISIBLE
         if (!isExporting)
-            subtitleTextView?.text = "Enter your password to decrypt the file"
+            subtitleTextView?.text = getString(R.string.enter_password_to_decrypt_file)
 
 
         dialog.window?.setDimAmount(0.8f)

app/src/main/java/ani/dantotsu/settings/SettingsDialogFragment.kt

@@ -12,7 +12,6 @@ import androidx.core.content.ContextCompat
 import androidx.core.view.isVisible
 import ani.dantotsu.BottomSheetDialogFragment
 import ani.dantotsu.MainActivity
-import ani.dantotsu.profile.ProfileActivity
 import ani.dantotsu.R
 import ani.dantotsu.connections.anilist.Anilist
 import ani.dantotsu.databinding.BottomSheetSettingsBinding
@@ -25,13 +24,15 @@ import ani.dantotsu.home.MangaFragment
 import ani.dantotsu.home.NoInternet
 import ani.dantotsu.incognitoNotification
 import ani.dantotsu.loadImage
-import ani.dantotsu.profile.activity.NotificationActivity
 import ani.dantotsu.offline.OfflineFragment
+import ani.dantotsu.profile.ProfileActivity
 import ani.dantotsu.profile.activity.FeedActivity
+import ani.dantotsu.profile.activity.NotificationActivity
 import ani.dantotsu.setSafeOnClickListener
 import ani.dantotsu.settings.saving.PrefManager
 import ani.dantotsu.settings.saving.PrefName
 import ani.dantotsu.startMainActivity
+import eu.kanade.tachiyomi.util.system.getSerializableCompat
 import java.util.Timer
 import kotlin.concurrent.schedule
 
@@ -42,7 +43,7 @@ class SettingsDialogFragment : BottomSheetDialogFragment() {
     private lateinit var pageType: PageType
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        pageType = arguments?.getSerializable("pageType") as? PageType ?: PageType.HOME
+        pageType = arguments?.getSerializableCompat("pageType") as? PageType ?: PageType.HOME
     }
 
     override fun onCreateView(

app/src/main/java/ani/dantotsu/settings/paging/NovelPagingSource.kt

@@ -41,13 +41,14 @@ import kotlinx.coroutines.withContext
 class NovelExtensionsViewModelFactory(
     private val novelExtensionManager: NovelExtensionManager
 ) : ViewModelProvider.Factory {
+    @Suppress("UNCHECKED_CAST")
     override fun <T : ViewModel> create(modelClass: Class<T>): T {
         return NovelExtensionsViewModel(novelExtensionManager) as T
     }
 }
 
 class NovelExtensionsViewModel(
-    private val novelExtensionManager: NovelExtensionManager
+    novelExtensionManager: NovelExtensionManager
 ) : ViewModel() {
     private val searchQuery = MutableStateFlow("")
     private var currentPagingSource: NovelExtensionPagingSource? = null
@@ -102,21 +103,20 @@ class NovelExtensionPagingSource(
         } else {
             availableExtensions.filter { it.name.contains(query, ignoreCase = true) }
         }
-        val filternfsw = filteredExtensions
         /*val filternfsw = if(isNsfwEnabled) {  currently not implemented
             filteredExtensions
         } else {
             filteredExtensions.filterNot { it.isNsfw }
         }*/
         return try {
-            val sublist = filternfsw.subList(
+            val sublist = filteredExtensions.subList(
                 fromIndex = position,
-                toIndex = (position + params.loadSize).coerceAtMost(filternfsw.size)
+                toIndex = (position + params.loadSize).coerceAtMost(filteredExtensions.size)
             )
             LoadResult.Page(
                 data = sublist,
                 prevKey = if (position == 0) null else position - params.loadSize,
-                nextKey = if (position + params.loadSize >= filternfsw.size) null else position + params.loadSize
+                nextKey = if (position + params.loadSize >= filteredExtensions.size) null else position + params.loadSize
             )
         } catch (e: Exception) {
             LoadResult.Error(e)