Clean redundant code

This commit is contained in:
Sadwhy 2024-12-11 15:25:19 +06:00 committed by GitHub
parent 6d32900568
commit 8ad8637fce
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -6,7 +6,6 @@ import android.view.View
import android.view.ViewGroup import android.view.ViewGroup
import ani.dantotsu.BottomSheetDialogFragment import ani.dantotsu.BottomSheetDialogFragment
import ani.dantotsu.databinding.BottomSheetProxyBinding import ani.dantotsu.databinding.BottomSheetProxyBinding
import ani.dantotsu.snackString
import ani.dantotsu.settings.saving.PrefManager import ani.dantotsu.settings.saving.PrefManager
import ani.dantotsu.settings.saving.PrefName import ani.dantotsu.settings.saving.PrefName
import ani.dantotsu.restartApp import ani.dantotsu.restartApp
@ -15,10 +14,10 @@ class ProxyDialogFragment : BottomSheetDialogFragment() {
private var _binding: BottomSheetProxyBinding? = null private var _binding: BottomSheetProxyBinding? = null
private val binding get() = _binding!! private val binding get() = _binding!!
private var proxyHost: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyHost) ?: "" private var proxyHost: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyHost).orEmpty()
private var proxyPort: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyPort) ?: "" private var proxyPort: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyPort).orEmpty()
private var proxyUsername: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyUsername) ?: "" private var proxyUsername: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyUsername).orEmpty()
private var proxyPassword: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyPassword) ?: "" private var proxyPassword: String? = PrefManager.getVal<String>(PrefName.Socks5ProxyPassword).orEmpty()
private var authEnabled: Boolean = PrefManager.getVal<Boolean>(PrefName.ProxyAuthEnabled) private var authEnabled: Boolean = PrefManager.getVal<Boolean>(PrefName.ProxyAuthEnabled)
private val proxyEnabled: Boolean = PrefManager.getVal<Boolean>(PrefName.EnableSocks5Proxy) private val proxyEnabled: Boolean = PrefManager.getVal<Boolean>(PrefName.EnableSocks5Proxy)
@ -39,16 +38,14 @@ class ProxyDialogFragment : BottomSheetDialogFragment() {
binding.proxyUsername.setText(proxyUsername) binding.proxyUsername.setText(proxyUsername)
binding.proxyPassword.setText(proxyPassword) binding.proxyPassword.setText(proxyPassword)
binding.proxyAuthentication.isChecked = authEnabled binding.proxyAuthentication.isChecked = authEnabled
binding.proxyUsername.isEnabled = authEnabled
binding.proxyPassword.isEnabled = authEnabled toggleAuthentication(authEnabled)
binding.proxyUsernameLayout.isEnabled = authEnabled
binding.proxyPasswordLayout.isEnabled = authEnabled
binding.proxySave.setOnClickListener { binding.proxySave.setOnClickListener {
proxyHost = binding.proxyHost.text.toString() ?: "" proxyHost = binding.proxyHost.text?.toString().orEmpty()
proxyPort = binding.proxyPort.text.toString() ?: "" proxyPort = binding.proxyPort.text?.toString().orEmpty()
proxyUsername = binding.proxyUsername.text.toString() ?: "" proxyUsername = binding.proxyUsername.text?.toString().orEmpty()
proxyPassword = binding.proxyPassword.text.toString() ?: "" proxyPassword = binding.proxyPassword.text?.toString().orEmpty()
PrefManager.setVal(PrefName.Socks5ProxyHost, proxyHost) PrefManager.setVal(PrefName.Socks5ProxyHost, proxyHost)
PrefManager.setVal(PrefName.Socks5ProxyPort, proxyPort) PrefManager.setVal(PrefName.Socks5ProxyPort, proxyPort)
@ -61,10 +58,22 @@ class ProxyDialogFragment : BottomSheetDialogFragment() {
binding.proxyAuthentication.setOnCheckedChangeListener { _, isChecked -> binding.proxyAuthentication.setOnCheckedChangeListener { _, isChecked ->
PrefManager.setVal(PrefName.ProxyAuthEnabled, isChecked) PrefManager.setVal(PrefName.ProxyAuthEnabled, isChecked)
binding.proxyUsername.isEnabled = isChecked toggleAuthentication(isChecked)
binding.proxyPassword.isEnabled = isChecked }
binding.proxyUsernameLayout.isEnabled = isChecked }
binding.proxyPasswordLayout.isEnabled = isChecked
private fun toggleAuthentication(isChecked: Boolean) {
arrayOf(
binding.proxyUsername,
binding.proxyPassword,
binding.proxyUsernameLayout,
binding.proxyPasswordLayout
).forEach {
it.isEnabled = isChecked
it.alpha = when (isChecked) {
true -> 1f
false -> 0.5f
}
} }
} }